Add generator runtime planning, bootstrap groundwork, settings documentation, scenario scaffold hooks, and xUnit smoke tests by cwinland · Pull Request #161 · cwinland/FastMoq

cwinland · 2026-05-02T22:12:05Z

Summary

Consolidates v5 generator foundation work including constructor planning, harness bootstrap metadata, generated-test settings model, scenario scaffold integration, and initial xUnit smoke-test emission.

Core Foundation (from #161)

Public constructor-planning contract via \InstanceConstructionRequest, \InstanceConstructionPlan, \InstanceConstructionParameterPlan, \InstanceConstructionParameterSource, and \Mocker.CreateConstructionPlan(...)\
Internal graph construction and harness-bootstrap descriptor layered on \Mocker.CreateConstructionPlan(...)\ and \MockerTestBase\
Shared package-layout and generated target-shape matrix from Define package-detection and target-test-shape rules for generated tests #127\ with analyzer package guidance
\FastMoq.Generators\ package with incremental generator for explicit partial \MockerTestBase\ targets
Representative generated consuming-scenario coverage, runtime parity tests, and benchmark evidence
Roadmap docs, solution/package/release wiring updates
Post-review hardening for planning semantics, analyzer performance, test-harness disposal

Settings & Documentation (from merged #163)

Generator groundwork documentation and validation patterns
Generated-test settings model and configuration contract for:
- Framework syntax targeting (xUnit availability gating)
- Test naming and output conventions
- Scaffold and bootstrap selection
- Runner/assertion style preferences
- Hook emission and regeneration behavior

Scenario Scaffold Integration (from merged #164)

Scenario scaffold hooks for setup composition and fixture patterns
TestClassExtensions and TestBase helpers for logging and validation
Shared setup scenario scaffold hooks

xUnit Smoke Tests (from merged #165)

xUnit [Fact]\ smoke-test emission for parameterless and optional-default public instance methods
Support for \Task, \Task, \ValueTask, \ValueTask\ return shapes
xUnit metadata-based availability gating (no emission if xUnit absent)
Deferred placeholders with skip reasons for unsupported patterns
C# keyword escaping in generated invocations (e.g., \component.@Class())

Framework Property Bridge (from merged #166)

\FastMoqGeneratedTestFramework\ MSBuild property wiring
CompilerVisibleProperty declaration and AnalyzerConfigOptionsProvider integration
Framework setting gating: when value is 'none' (case-insensitive), xUnit smoke-test emission suppressed unconditionally

Validation

\dotnet test FastMoq.Tests/FastMoq.Tests.csproj --no-restore\
\dotnet test FastMoq.Analyzers.Tests/FastMoq.Analyzers.Tests.csproj --no-restore\
\dotnet test FastMoq.Tests.Web/FastMoq.Tests.Web.csproj --no-restore\
All tests passing: 966+ total across net8.0/net9.0/net10.0

Tracking

Builds on V5 tracker: FastMoq generator package shape and MVP contract #120\
Closes Coordinate runtime prerequisites for generator-targeted output #121, Implement compile-time test graph and harness generation MVP #122, Define generator-targeted graph metadata hooks and constructor-selection contract #125, Define package-detection and target-test-shape rules for generated tests #127\
Includes merged work from Define generated-test settings and test-platform targeting for later generation flows #162\ (settings platform targeting)
Includes merged work from Add generator groundwork and document generated-test settings #163\ (generator groundwork and settings documentation)
Includes merged work from Add generated shared setup scenario scaffold hooks #164\ (scenario scaffold hooks)
Includes merged work from Widen generated harness smoke test coverage #165\ (xUnit smoke tests - merged to Implement generated scenario and suite scaffolding after graph and harness MVP #136)
Includes merged work from feat(generators): wire FastMoqGeneratedTestFramework MSBuild property into generator pipeline (#123 slice 2) #166\ (framework property bridge - merged to Widen generated harness smoke test coverage #165)
Follow-on work remains in Define generator-stable ScenarioBuilder scaffolding hooks #126, Normalize blocking generator-targeted helper surfaces for logging, HTTP, Azure, Azure Functions, and typed DI #134, Implement generated scenario and suite scaffolding after graph and harness MVP #136, Implement generator-backed framework-helper builders for repeated test patterns #137, Generate provider-first tests from existing services and supported classes #123, and Analyzer should suggest generating tests for supported untested code and required FastMoq packages #124
"@; = @{ title = Add generator runtime planning, bootstrap groundwork, settings documentation, scenario scaffold hooks, and xUnit smoke tests; body = } | ConvertTo-Json; = Invoke-RestMethod -Uri "https://api.github.com/repos/cwinland/FastMoq/pulls/161" -Method Patch -Headers System.Collections.Hashtable -Body ; "PR Add generator runtime planning, bootstrap groundwork, settings documentation, scenario scaffold hooks, and xUnit smoke tests #161 updated:
Title: "

Co-authored-by: Copilot <copilot@github.com>

Copilot

Pull request overview

This PR introduces generator-targeted constructor planning and internal bootstrap metadata in FastMoq by adding a public “request → plan” contract on Mocker, layering an internal construction graph and harness-bootstrap descriptor on top of that contract, and wiring MockerTestBase<TComponent> to expose these surfaces for future generator consumption.

Changes:

Add public construction-planning contract (InstanceConstructionRequest/InstanceConstructionPlan/InstanceConstructionParameterPlan/InstanceConstructionParameterSource) and Mocker.CreateConstructionPlan(...).
Add internal metadata layers (InstanceConstructionGraph, ComponentHarnessBootstrapDescriptor) plus MockerTestBase<TComponent> accessors.
Add focused runtime tests, update generator roadmap docs, and migrate test assertions from FluentAssertions to AwesomeAssertions.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
docs/roadmap/generator-roadmap.md	Updates roadmap contract notes and records completed `#122` groundwork status.
docs/roadmap/README.md	Summarizes current status/direction for `#125` and `#122` in the roadmap index.
Directory.Packages.props	Removes FluentAssertions central version entry.
FastMoq/packages.lock.json	Updates locked dependency graph (incl. transitive updates).
FastMoq.Core/Models/InstanceConstructionRequest.cs	Adds the public request model for constructor-selection intent.
FastMoq.Core/Models/InstanceConstructionPlan.cs	Adds the public resolved-plan model + parameter plan + parameter source enum.
FastMoq.Core/Models/InstanceConstructionGraph.cs	Adds internal graph node/edge metadata layered over the plan.
FastMoq.Core/Models/ComponentHarnessBootstrapDescriptor.cs	Adds internal harness bootstrap descriptor for generator-targeted mapping.
FastMoq.Core/Mocker.ConstructionPlan.cs	Implements `CreateConstructionPlan(...)`, plus internal graph creation and request mapping helpers.
FastMoq.Core/KnownTypeRegistry.cs	Adds helper predicates to detect known-type managed and parameter resolution.
FastMoq.Core/MockerTestBase_Constructors.cs	Exposes planning/graph/bootstrap descriptor accessors on `MockerTestBase<TComponent>`.
FastMoq.Tests/InstanceConstructionPlanTests.cs	Adds tests covering plan output across multiple resolution categories.
FastMoq.Tests/InstanceConstructionGraphTests.cs	Adds tests for internal graph projection and harness hook mapping.
FastMoq.Tests/MockerTestBaseConstructionPlanTests.cs	Adds tests for `MockerTestBase<TComponent>` planning and bootstrap descriptor behavior.
FastMoq.Tests/GlobalUsings.cs	Switches assertions global usings to AwesomeAssertions.
FastMoq.Tests/FastMoq.Tests.csproj	Replaces FluentAssertions with AwesomeAssertions package reference.
FastMoq.Tests.Web/GlobalUsings.cs	Switches assertions global usings to AwesomeAssertions in web test project.
FastMoq.Tests/InternalSampleServiceTests.cs	Removes now-unneeded FluentAssertions using.

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 6 comments.

…etadata-slice

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 10 comments.

@Class

* Document generated-test settings design for #162 * Fix generated harness parameterless constructor selection * Define #126 scenario scaffolding contract * Document #134 helper-family narrowing matrix * Align generator project GUID across solutions * Add generated shared setup scenario scaffold hooks (#164) * Expand generated scenario scaffold executors * Add generated shared setup scaffold hooks * Strengthen generated shared setup hook ordering test * Document generated scenario scaffold members * docs: align generator roadmap with current scope * Widen generated harness smoke test coverage (#165) * Widen generated harness smoke test coverage * Fix: Escape C# keywords in generated method invocations When component methods are named with C# keywords (e.g., @Class, @return), the unescaped IMethodSymbol.Name resulted in invalid emitted code like 'component.class()' instead of 'component.@Class()'. - Add EscapeIdentifierIfKeyword helper using SyntaxFacts.GetKeywordKind - Apply escaping in CreateGeneratedTestMethodModel to all method references - Add [Fact] test covering keyword methods (@Class, @interface, @return) Addresses code review comment on GeneratedHarnessSourceGenerator.cs * feat(generators): wire FastMoqGeneratedTestFramework MSBuild property into generator pipeline (#123 slice 2) (#166) Wire FastMoqGeneratedTestFramework MSBuild property into generator pipeline - Add CompilerVisibleProperty for FastMoqGeneratedTestFramework to generator csproj - Read build_property.FastMoqGeneratedTestFramework in incremental pipeline via AnalyzerConfigOptionsProvider - Combine frameworkSetting with targets pipeline; pass to EmitSource - When value is 'none' (case-insensitive), suppress xUnit smoke-test emission regardless of metadata - Add TestAnalyzerConfigOptionsProvider / TestAnalyzerConfigOptions nested helpers for test isolation - Add 3 new [Fact] tests covering none suppression, explicit xunit enable, and case-insensitive none Part of #123

Copilot

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 44 out of 44 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 45 out of 46 changed files in this pull request and generated 1 comment.

+                case float floatValue:
+                    expression = floatValue.ToString("R", CultureInfo.InvariantCulture) + "F";
+                    return true;
+                case double doubleValue:
+                    expression = doubleValue.ToString("R", CultureInfo.InvariantCulture);
+                    return true;


cwinland and others added 5 commits May 2, 2026 15:37

Add constructor planning contract for #125

94ca654

Add internal construction graph metadata for #122

1f77bda

Update to awesomeAssertions

ae4cde3

fix static assertion calls

9af1453

Co-authored-by: Copilot <copilot@github.com>

Add harness bootstrap descriptor groundwork for #122

5e6b67f

Copilot AI review requested due to automatic review settings May 2, 2026 22:12

Copilot started reviewing on behalf of cwinland May 2, 2026 22:12 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

Comment thread FastMoq.Core/Mocker.ConstructionPlan.cs Outdated

Comment thread FastMoq.Core/Mocker.ConstructionPlan.cs

Comment thread FastMoq.Core/Mocker.ConstructionPlan.cs

Add generated test package matrix rules

c159ed8

cwinland mentioned this pull request May 2, 2026

Define package-detection and target-test-shape rules for generated tests #127

Closed

7 tasks

Add first harness source generator slice

d94c774

Copilot AI review requested due to automatic review settings May 2, 2026 23:22

Copilot started reviewing on behalf of cwinland May 2, 2026 23:23 View session

cwinland mentioned this pull request May 2, 2026

Implement compile-time test graph and harness generation MVP #122

Closed

14 tasks

Copilot AI reviewed May 2, 2026

View reviewed changes

cwinland added 2 commits May 3, 2026 06:35

Complete #122 parity, benchmark, and roadmap updates

563c8d8

Merge remote-tracking branch 'origin/master' into feature/122-graph-m…

9a05c47

…etadata-slice

Copilot AI review requested due to automatic review settings May 3, 2026 13:19

Copilot started reviewing on behalf of cwinland May 3, 2026 13:20 View session

cwinland self-assigned this May 3, 2026

Copilot AI reviewed May 3, 2026

View reviewed changes

Comment thread FastMoq.Analyzers/Analyzers/MissingHelperPackageAnalyzer.cs Outdated

Comment thread FastMoq.Analyzers/Analyzers/MissingHelperPackageAnalyzer.cs Outdated

Comment thread FastMoq.code-workspace

cwinland mentioned this pull request May 3, 2026

Define generator-targeted graph metadata hooks and constructor-selection contract #125

Closed

10 tasks

cwinland added 2 commits May 3, 2026 09:34

Code Review Fixes

c3cd0c8

Address PR review follow-up comments

02c163f

Copilot AI review requested due to automatic review settings May 3, 2026 13:57

Copilot started reviewing on behalf of cwinland May 3, 2026 13:57 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

Comment thread FastMoq.Core/Mocker.ConstructionPlan.cs Outdated

Comment thread FastMoq.Analyzers/FastMoqAnalysisHelpers.cs Outdated

Fix latest PR review findings

cdc2cb1

cwinland requested a review from Copilot May 3, 2026 15:08

Copilot started reviewing on behalf of cwinland May 3, 2026 15:09 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

cwinland and others added 2 commits May 3, 2026 12:01

Dispose construction plan test harnesses

46bb2d7

Copilot AI review requested due to automatic review settings May 6, 2026 19:32

Copilot started reviewing on behalf of cwinland May 6, 2026 19:33 View session

cwinland changed the title ~~Add generator runtime planning and bootstrap groundwork~~ Add generator runtime planning, bootstrap groundwork, settings documentation, scenario scaffold hooks, and xUnit smoke tests May 6, 2026

Merge branch 'master' into feature/122-graph-metadata-slice

871a286

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread FastMoq.Benchmarks/GeneratedHarnessSetupBenchmarks.cs

cwinland added 2 commits May 6, 2026 16:14

Add Code review instructions

1f33604

Support nested generated harness targets

739d2d2

Copilot AI review requested due to automatic review settings May 6, 2026 20:28

Copilot started reviewing on behalf of cwinland May 6, 2026 20:29 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread FastMoq.Generators/GeneratedHarnessSourceGenerator.cs

Comment thread docs/roadmap/generated-test-settings.md

Comment thread FastMoq.Analyzers.Tests/FastMoq.Analyzers.Tests.csproj

cwinland added 2 commits May 6, 2026 16:59

Refresh generated harness benchmark results

45bfeb5

Add generator release tracking metadata

4dd0fc9

Copilot AI review requested due to automatic review settings May 6, 2026 21:06

Copilot started reviewing on behalf of cwinland May 6, 2026 21:07 View session

Address remaining PR review findings

7d16d0f

Copilot AI reviewed May 6, 2026

View reviewed changes

Conversation

cwinland commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Core Foundation (from #161)

Settings & Documentation (from merged #163)

Scenario Scaffold Integration (from merged #164)

xUnit Smoke Tests (from merged #165)

Framework Property Bridge (from merged #166)

Validation

Tracking

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cwinland commented May 2, 2026 •

edited

Loading